Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --all flag to delete all locally available models #1317

Merged
merged 7 commits into from
Nov 7, 2024

Conversation

JoyProg
Copy link
Contributor

@JoyProg JoyProg commented Oct 10, 2024

Description

This feature enhances Ersilia's delete command by adding the functionality to delete multiple models.

Changes Made

  • Implemented a delete all models feature.
  • Refactored the code to eliminate redundancy, ensuring both single and multiple model deletions now call a base method by passing in the model ID.

Related to #1265

@P-Mefut
Copy link

P-Mefut commented Oct 10, 2024

Hi @JoyProg could you please share your logs output, I've tried running test and I'm getting a no such option for the --all tag

output.log

@JoyProg
Copy link
Contributor Author

JoyProg commented Oct 10, 2024

Hi @P-Mefut. I do not get the error. I've attached the log file. Can you verify if the file you have locally reflects the changes?
output.log

@JoyProg
Copy link
Contributor Author

JoyProg commented Oct 10, 2024

Hi @P-Mefut, are you still getting the same output?

@DhanshreeA
Copy link
Member

Hi @P-Mefut, are you still getting the same output?

I'll check this. Thanks @JoyProg

@P-Mefut
Copy link

P-Mefut commented Oct 12, 2024

Hi @DhanshreeA I've checked again and everything is in good standing, the code works just fine👍

ersilia/cli/commands/delete.py Show resolved Hide resolved
ersilia/cli/commands/delete.py Show resolved Hide resolved
@dzumii
Copy link
Contributor

dzumii commented Oct 16, 2024

Hello @JoyProg have you implemented the requested changes here?

@DhanshreeA DhanshreeA merged commit 658a460 into ersilia-os:master Nov 7, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants